CLOUDSTACK-10245: Fix password server#2419
Conversation
In case of isolated, both self.config.is_vpc() and self.config.is_router() are false, but self.config.is_dhcp() is true. Moved the password server logic to the `if has_metadata` block, as this is valid for all 3 systemvm types.
smeetsr
left a comment
smeetsr
left a comment
There was a problem hiding this comment.
Executed full Nuage regression for this fix.
Executed test/integration/plugins/nuagevsp/test_nuage_password_reset.py
Test user data and password reset functionality with ... === TestName: test_nuage_UserDataPasswordReset | Status : SUCCESS ===
ok
Ran 1 test in 607.211s
OK
Executed test/integration/plugins/nuagevsp/test_nuage_vpc_internal_lb.py
Test Nuage VSP VPC Offering with different combinations of LB ... === TestName: test_01_nuage_internallb_vpc_Offering | Status : SUCCESS ===
ok
Test Nuage VSP VPC Network Offering with and without Internal LB ... === TestName: test_02_nuage_internallb_vpc_network_offering | Status : SUCCESS ===
ok
Test Nuage VSP VPC Networks with and without Internal LB service ... === TestName: test_03_nuage_internallb_vpc_networks | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality with different ... === TestName: test_04_nuage_internallb_rules | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality by performing (wget) ... === TestName: test_05_nuage_internallb_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality with different LB ... === TestName: test_06_nuage_internallb_algorithms_traffic | Status : SUCCESS ===
ok
Test Nuage VSP VPC Internal LB functionality with restarts of VPC ... === TestName: test_07_nuage_internallb_vpc_network_restarts_traffic | Status : SUCCESS ===
ok
Ran 7 tests in 6401.312s
OK
- executed all other nuagevsp regression tests to verify this fix.
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1669 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-2183)
|
|
Merging this based on test results and code reviews. |
6 participants
In case of isolated networks where VR is not the gateway, both self.config.is_vpc() and self.config.is_router() are false,
but self.config.is_dhcp() is true.
Moved the password server logic to the
if has_metadatablock,as this is valid for all 3 systemvm types.